Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: logics #97

Closed
aarnphm opened this issue Jun 30, 2023 · 1 comment
Closed

refactor: logics #97

aarnphm opened this issue Jun 30, 2023 · 1 comment

Comments

@aarnphm
Copy link
Member

aarnphm commented Jun 30, 2023

Right now there are too much coupling with how start and build interact

We need to resolve:

  • If the given model_id is a pretrained path?
  • If the given model_id is a custom file path?
    • Do we create a new model entry to the ModelStore?
      • This should be the behaviour since ModelStore changed a bit in BentoML from 1.0.23
    • Do we only include this entry into the Bento during the build?

Right now service starts relies on environment, so it is working for now, but very fragile

I will work on this during the weekend
@aarnphm aarnphm closed this as completed Jul 5, 2023
@aarnphm
Copy link
Member Author

aarnphm commented Jul 5, 2023

addressed on 0.1.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aarnphm