Skip to content

Commit

Permalink
[JIT] Fix incorrect definition for constant VectorConvertX2X
Browse files Browse the repository at this point in the history
  • Loading branch information
DrChat committed Mar 3, 2018
1 parent 3a8f8f2 commit 894bbf9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions src/xenia/cpu/compiler/passes/constant_propagation_pass.cc
Original file line number Diff line number Diff line change
Expand Up @@ -702,16 +702,15 @@ bool ConstantPropagationPass::Run(HIRBuilder* builder) {
if (i->src1.value->IsConstant()) {
v->set_zero(VEC128_TYPE);
v->VectorConvertF2I(i->src1.value,
!!(i->flags & ARITHMETIC_UNSIGNED),
!!(i->flags & ARITHMETIC_SATURATE));
!!(i->flags & ARITHMETIC_UNSIGNED));
i->Remove();
}
break;
case OPCODE_VECTOR_CONVERT_I2F:
if (i->src1.value->IsConstant()) {
v->set_zero(VEC128_TYPE);
v->VectorConvertI2F(i->src1.value,
!!(i->flags & ARITHMETIC_SATURATE));
!!(i->flags & ARITHMETIC_UNSIGNED));
i->Remove();
}
break;
Expand Down
2 changes: 1 addition & 1 deletion src/xenia/cpu/hir/value.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1090,7 +1090,7 @@ void Value::VectorConvertI2F(Value* other, bool is_unsigned) {
}
}

void Value::VectorConvertF2I(Value* other, bool is_unsigned, bool saturate) {
void Value::VectorConvertF2I(Value* other, bool is_unsigned) {
assert_true(type == VEC128_TYPE);

// FIXME(DrChat): This does not saturate!
Expand Down
2 changes: 1 addition & 1 deletion src/xenia/cpu/hir/value.h
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ class Value {
void VectorCompareUGT(Value* other, TypeName type);
void VectorCompareUGE(Value* other, TypeName type);
void VectorConvertI2F(Value* other, bool is_unsigned);
void VectorConvertF2I(Value* other, bool is_unsigned, bool saturate);
void VectorConvertF2I(Value* other, bool is_unsigned);
void VectorShl(Value* other, TypeName type);
void VectorShr(Value* other, TypeName type);
void VectorRol(Value* other, TypeName type);
Expand Down

0 comments on commit 894bbf9

Please sign in to comment.