Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-web platforms #3

Open
benwiley4000 opened this issue Mar 18, 2018 · 2 comments
Open

Support non-web platforms #3

benwiley4000 opened this issue Mar 18, 2018 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@benwiley4000
Copy link
Owner

The use of the DOM api to polyfill fragment means this isn't usable on other platforms.

@wishfoundry
Copy link

can't you just replace this with something like:

function Fragment(props) {
    return props.children;
}

@benwiley4000
Copy link
Owner Author

@wishfoundry I might be missing some context, which you could explain, but I don't think that would work for a couple of reasons:

  1. Array-as-render-result requires keys on each list item whereas Fragment does not.
  2. Array-as-render-result isn't supported prior to React 16. A goal of this lib is to support React 15.

@benwiley4000 benwiley4000 added the help wanted Extra attention is needed label Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants