Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code is not minified #15

Open
samfundev opened this issue Aug 28, 2023 · 2 comments
Open

Code is not minified #15

samfundev opened this issue Aug 28, 2023 · 2 comments

Comments

@samfundev
Copy link

Minification is currently disabled. Could it be re-enabled?

@benwinding
Copy link
Owner

Kind of intentional, the chrome and firefox stores don't like minification, as it makes their reviewing much harder 😟
Does it reduce the bundle by that much?

@samfundev
Copy link
Author

Minifying content.js saves about 67.77 kB. It also looks like there might be two copies of react and react-dom included. One in content.js and another in the vendor folder. Which if that's true, it could reduce things further.

I am more concerned about the content.js since the extension runs on every page. Which I assume that means it effects the memory and execution of every page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants