Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React-Admin v3 #46

Closed
6 of 7 tasks
LaszloDev opened this issue Sep 9, 2019 · 9 comments · Fixed by #67
Closed
6 of 7 tasks

Update to React-Admin v3 #46

LaszloDev opened this issue Sep 9, 2019 · 9 comments · Fixed by #67
Labels
enhancement New feature or request

Comments

@LaszloDev
Copy link
Collaborator

LaszloDev commented Sep 9, 2019

React-Admin planning to release v3 this summer. Right now they are finalizing the alpha and started to preparing the migration guide.
Are there any plans to start migrating this package to work with v3? I did a quick check yesterday and there are some breaking changes that will be impacting this package.

https://github.com/marmelab/react-admin/releases

Next branch: https://github.com/marmelab/react-admin/blob/next/UPGRADE.md

TODOs

Thanks to @simonberger (#67)

  • Update docs

Beta Version

We are getting closer to the stable version of this package which supports react-admin v3. Thanks to @simonbuerger he provided a pull request (#67) with the needed work.

To try the beta version of the package use the following to manually update the package in your project (for npm use npm install):

  • update react-admin to the lastest version
  • npm install / yarn add github:benwinding/react-admin-firebase#upgrade-to-react-admin-v3
@benwinding
Copy link
Owner

Hi @LaszloDev,

Yes sounds good, maybe we could version up the npm library to 3.0 to be inline with the react-admin versioning (and easier for users).

I'll keep this branch here for version 3 upgrades if anyone wants to contribute:

https://github.com/benwinding/react-admin-firebase/tree/upgrade-to-react-admin-v3

Cheers,
Ben

@LaszloDev
Copy link
Collaborator Author

Hey @benwinding,
thanks for providing a new branch. Could you create a GitHub project for it, so we can keep track of the tasks needed to be done for v3.0 as a milestone?

@benwinding
Copy link
Owner

Hey @LaszloDev,
Great idea, I've added a project to track the progress here:

https://github.com/benwinding/react-admin-firebase/projects/1

The hardest thing to change is probably the AuthProvider. They've removed actions, which our implementation relies on (USER_LOGIN, USER_LOGOUT, USER_CHECK), so we'll need to figure out a new way using hooks.

If anyone would like to start working on this with me, let me know!

Cheers,
Ben

@LaszloDev
Copy link
Collaborator Author

v3 migration:
ra-realtime has been removed - marmelab/react-admin#3908 (comment)

Please add that to the project

@simonbuerger simonbuerger mentioned this issue Dec 2, 2019
7 tasks
@LaszloDev LaszloDev changed the title Preparation for React-Admin v3 Update to React-Admin v3 Jan 5, 2020
@LaszloDev
Copy link
Collaborator Author

To check out the beta release with react-admin support in your local project:
yarn add github:benwinding/react-admin-firebase#upgrade-to-react-admin-v3

@LaszloDev LaszloDev added the enhancement New feature or request label Jan 5, 2020
@valentinalexeev
Copy link

Dear @LaszloDev, I have created my own AuthProvider for v3 that follows the new spec and also relies on FirebaseUI for the logic of providers/methods/etc...

See https://gist.github.com/valentinalexeev/594fb2e1268851c60a9252b777655a63

I can also create a pull request if you find it useful.

@RWOverdijk
Copy link
Contributor

@benwinding Did you close this because it works now, or because... I don't know, other reasons.

@benwinding
Copy link
Owner

Hi @RWOverdijk ,

Sorry about the delay but the upgrade is finished and merged into master #67 (which automatically closed this issue)

It's deployed to npm under the major version 3.0.0 https://www.npmjs.com/package/react-admin-firebase/v/3.0.0

Check it out and let me know if there's any issues,

Cheers,
Ben

@RWOverdijk
Copy link
Contributor

Aye. I also see the default query stuff has been added. That's cool because I've spent the past year yelling at my screen. Nice work man :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants