-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to React-Admin v3 #46
Comments
Hi @LaszloDev, Yes sounds good, maybe we could version up the npm library to 3.0 to be inline with the I'll keep this branch here for version 3 upgrades if anyone wants to contribute: https://github.com/benwinding/react-admin-firebase/tree/upgrade-to-react-admin-v3 Cheers, |
Hey @benwinding, |
Hey @LaszloDev, https://github.com/benwinding/react-admin-firebase/projects/1 The hardest thing to change is probably the AuthProvider. They've removed actions, which our implementation relies on (USER_LOGIN, USER_LOGOUT, USER_CHECK), so we'll need to figure out a new way using hooks. If anyone would like to start working on this with me, let me know! Cheers, |
v3 migration: Please add that to the project |
To check out the beta release with |
Dear @LaszloDev, I have created my own AuthProvider for v3 that follows the new spec and also relies on FirebaseUI for the logic of providers/methods/etc... See https://gist.github.com/valentinalexeev/594fb2e1268851c60a9252b777655a63 I can also create a pull request if you find it useful. |
@benwinding Did you close this because it works now, or because... I don't know, other reasons. |
Hi @RWOverdijk , Sorry about the delay but the upgrade is finished and merged into master #67 (which automatically closed this issue) It's deployed to npm under the major version Check it out and let me know if there's any issues, Cheers, |
Aye. I also see the default query stuff has been added. That's cool because I've spent the past year yelling at my screen. Nice work man :) |
React-Admin planning to release v3 this summer. Right now they are finalizing the alpha and started to preparing the migration guide.
Are there any plans to start migrating this package to work with v3? I did a quick check yesterday and there are some breaking changes that will be impacting this package.
https://github.com/marmelab/react-admin/releases
Next branch: https://github.com/marmelab/react-admin/blob/next/UPGRADE.md
TODOs
Thanks to @simonberger (#67)
Beta Version
We are getting closer to the stable version of this package which supports
react-admin
v3. Thanks to @simonbuerger he provided a pull request (#67) with the needed work.To try the beta version of the package use the following to manually update the package in your project (for npm use
npm install
):react-admin
to the lastest versionnpm install
/yarn add github:benwinding/react-admin-firebase#upgrade-to-react-admin-v3
The text was updated successfully, but these errors were encountered: