Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect keys in Location updates dictionary #1

Closed
byroncoetsee opened this issue Aug 29, 2017 · 2 comments
Closed

Incorrect keys in Location updates dictionary #1

byroncoetsee opened this issue Aug 29, 2017 · 2 comments

Comments

@byroncoetsee
Copy link

Hey there,

Thanks for the awesome library :)

I have one issue and one suggestion... If I may...

/**
     *   Gives an Location Dictionary using keys BB_LATITUDE, BB_LONGITUDE, BB_ALTITUDE
     */
    public func bbLocationManagerDidUpdateLocation(_ latLongAltitudeDictionary: [AnyHashable : Any]!) {  }

Those keys are incorrect. The keys used in the dictionary seem to be latitude, longitude and altitude.

Suggestion:

Maybe make some of the the delegate methods optional so we don't have to include all of them in the delegate class :)

Cheers!

@benzamin
Copy link
Owner

benzamin commented Aug 29, 2017

Hey Byron,
Thanks for you issue and suggestion. Here are the answers:

Issue: Actually BB_LATITUDE, BB_LONGITUDE, BB_ALTITUDE aren't keys, the are defined macros whose actual string values are "latitude", "longitude" and "altitude". As the documentation says the are keys, that's why the confusion. I'm updating my documentation, thanks for pointing out!
Suggestion: I totally agree with you. Will make only one delegate method as required.

Thanks again 👍

@byroncoetsee
Copy link
Author

Ah ok I see!

Awesome. And thank you, again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants