Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharps only #42

Open
Ged2323 opened this issue Nov 17, 2017 · 0 comments
Open

Sharps only #42

Ged2323 opened this issue Nov 17, 2017 · 0 comments

Comments

@Ged2323
Copy link

Ged2323 commented Nov 17, 2017

Hi,
I've been having a look at this great resource and was wondering how we would go about making sure when you print the scale like A Major it prints --> [A4, B4, C♯5, D5, E5, F♯5, A♭5]
Though A major only has sharps. So the A♭5 should be G#5. I'm looking in the Pitch.swift file and wondering would this be the place to assign the Note and Sharp type if it is a sharp key?
Thanks in advance for your help.
I look forward to talking with you.
Regards Gerard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant