-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multilanguage interface for tasmocompiler #40
Comments
It's gonna be a challenge... but I think it is doable. I will think about it. |
@benizno77 Please take care that is just "nice o have". But if you can and don't require so big changes why not. Of course if it require a lot of job please post in "nice to have" priority. I believe that the other request "Use personal fork of tasmota firmware for compilation" could be more interesting. Thanks. |
It's a very good idea, I can try to help you with Spanish translation, 😜 We can try it with i18next library and react-i18next (React implementation of i18next library), for example. |
That's true. I have no time to have a look in it a little bit deeper... But PRs are welcome ;) |
I'll try it, but I'm not sure I'll make it, I've never programmed with NodeJS and React before... xD |
@benzino77 I'm finally doing the translation with the integration of the "react-intl" library. When I finish translating the texts into Spanish I do the PR so that @bovirus can translate the texts into Italian in the it.json |
Looks very promising! I'm waiting for a PR to review. |
Please consider if you can to modify the source to move the two parameters web address of tasmota repository in a separate file (ex. settings.json) Could be usefull for example when I want as I did make a fork of tasmocompielr repository to use for tasmota firmware my personal fork of tasmota repository and as default language for firmware a different language than English (for me is Italian). Thanks. |
It was created to compile vanilla Tasmota code. If you want to compile your own fork of Tasmota then you have to follow the ADVANCED guide. There is a feature request #38 to allow save configuration to file and then reload it which, in some sense, can address your needs. |
#benzino77 Currently to the job that I explained (test GUI functionality with separate tasmta fork) I have to change the file of source code.
in a specific resource file (settings) Please take care that I didn't ask another option. For me It means to have a code more clear and simple to change (in the part that can be changed). Thanks. |
it is already in special config file which is called: |
@benzino77 no There are two times settings tasmota github repository in these files file /server/config/config.js And in /server/config/config.js is not defined the default language GUI for build. The idea a could be a source code change where all settings are in /server/config/config.js File /Dockerfilr read the settings of tasmota github address in /server/config/config.js and src/component/AppStepper/VersioneStepper/Variables/Languages.js set default language for build based on default language stored in /server/config/config.js |
One thing is to translate the interface to different languages (the subject of this issue), another thing is to pre-select the default language for the firmware (which I'm trying to include in the final PR) and finally the request to be able to change the repository to use Tasmota (not about this issue/enhancement). |
@bovirus I have added auto-selection of the firmware language based on the user's web browser (independently of the languages supported by the Web UI) on Pull Request. For example, now only english, spanish and italian are supported for web ui (you can help with One problem solved!! |
Many thanks for your help & change about source code. Small OT. I saw that you have a big knowledge about development. |
Addressed in #50 |
Could be possible to have a multi-language interface for the online compiler?
If you move all strings used in an external file I can help to translate in other language (ex. Italian)
Thanks. KR.
The text was updated successfully, but these errors were encountered: