New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect option header name #54

Closed

ghost opened this issue Nov 4, 2020 · 1 comment

ghost commented Nov 4, 2020 •

edited by ghost

It tries to get the value of $this->config['x-power-by'] when it should be $this->config['x-powered-by']

See: https://github.com/bepsvpt/secure-headers/blob/master/src/SecureHeaders.php#L230

PR: #55

Thanks.

ghost mentioned this issue

Fixed incorrect option header name. #55

Closed

Owner

bepsvpt commented Dec 3, 2020

This is expected behavior because older version use incorrect key name, you can find it from #50 and b405451.

$this->config['x-powered-by'] ?? ($this->config['x-power-by'] ?? '')

To prevent breaking change, it will use x-powered-by key first. If x-powered-by does not exist, it will use x-power-by.

ghost closed this as completed

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment