Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing CollidableReference kinematic vs dynamic distinction #44

Closed
RossNordby opened this issue Sep 20, 2018 · 1 comment
Closed

Comments

@RossNordby
Copy link
Member

At the moment, it doesn't look like the kinematic state is used anywhere. It was a holdover from when special case handling was being considered. Unless we bring back something like #17, there doesn't seem to be a reason for this.

It's also a little confusing for a user to get a CollidableReference in a callback that has three potential mobility types plus a handle, but there are only two potential handle spaces- bodies and statics.

@RossNordby
Copy link
Member Author

CollidableReferences are used by the narrow phase to avoid creating constraints that don't involve at least one dynamic. While it's possible to go grab body inertia information and recalculate the kinematic state on demand, it's cheaper to just use the mobility state.

So that's staying. BodyActivity.Kinematic, however, is completely redundant and is going away. 6460c10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant