identifierFormat example for ADFS not correct

[cburatto]

On the documentation, Usage with Active Directory Federation Services:

{
entryPoint: 'https://ad.example.net/adfs/ls/',
issuer: 'https://your-app.example.net/login/callback',
callbackUrl: 'https://your-app.example.net/login/callback',
cert: 'MIICizCCAfQCCQCY8tKaMc0BMjANBgkqh ... W==',
authnContext: 'http://schemas.microsoft.com/ws/2008/06/identity/authenticationmethod/windows',
identifierFormat: null
}

However, the metadata generated by generateServiceProviderMetadata shows an empty <NameIDFormat/>.

This seems to be because the saml.js code is:

if (options.identifierFormat === undefined) {
    options.identifierFormat = "urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress";
  }

It should probably test for undefined and null.

[cburatto]

Scrap that: it seems you can really NOT send any identifier on the request, and the only way to do that is using identifierFormat = null. If you simply ommit identifierFormat from the options, it will default to urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress.