Document the skipRequestCompression #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some providers don't support SAML compression, or they don't support compressed SAML requests if the assertions is configured to be uncompressed. So having the skipRequestCompression is nice, and highlighting it in documentation makes it easier for people configuring an SP app through trail and error (not all IDPs gives much in terms of error codes and error messages).
|
Thanks for the PR! |
ploer
added a commit
that referenced
this pull request
Nov 1, 2015
Document the skipRequestCompression
|
The big problem is that passport-saml does not indicate that the request has been compressed. to indicate towards the identity provider that the request should be decompressed first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some providers don't support SAML compression, or they don't support compressed SAML requests if the assertions is configured to be uncompressed.
So having the skipRequestCompression is nice, and highlighting it in documentation makes it easier for people configuring an SP app through trail and error (not all IDPs gives much in terms of error codes and error messages).
I ran into this issue when setting up and app to work with okta. Except for the SAML request compression issue this library works great (granted I had to contact okta support got even figure out that request compression was an issue, but that's their fault for not having error codes, system logs or debug information of any kind).