Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mio 0.7 support #23

Closed
jmaygarden opened this issue Dec 11, 2020 · 10 comments
Closed

mio 0.7 support #23

jmaygarden opened this issue Dec 11, 2020 · 10 comments

Comments

@jmaygarden
Copy link

jmaygarden commented Dec 11, 2020

I was about to fork and add support for mio 0.7. It's mostly a matter of switching from Evented to event::Source. However, @raffber has already done so in raffber/mio-serial. It would be great if his change could be pulled in and pushed to crates.io.

@berkowski
Copy link
Owner

A quick glance through @raffber's changes for mio-serial and tokio-serial looks OK. I haven't had any use of tokio-serial for a good while now but I can pull his changes in and push new versions to crates.io

@berkowski
Copy link
Owner

Actually, looking closer none of the AsyncRead or AsyncWrite methods are implemented..

@raffber
Copy link

raffber commented Dec 13, 2020

Yes, I have not done any significant work on this, since I quickly realized that I was stuck with tokio 0.2 / mio 0.6 due to some other dependencies. You can disregard my fork for the time being.

I might pick it back up in a few weeks but unfortunately I don't have time to work on this atm.

@berkowski
Copy link
Owner

Finally have some time to start moving on this. On unix things look straight forward. I'm waiting for guidance from tokio-rs/mio#1460

@berkowski
Copy link
Owner

Preliminary support for mio 0.7 has been added to the v4.0 branch

@ColinFinck
Copy link
Collaborator

I've tested the read_serialport example of the "v4.0_serialstream" branch under Windows and Linux and it works fine for me.
What is blocking the release of mio-serial v4.0?

@ColinFinck
Copy link
Collaborator

Bump

tokio 1.7.0 has just been released with support for Windows Named Pipes. This finally enables your v4.4.0_serialstream branch of tokio-serial to be finished for Windows, and thereby release an updated tokio-serial for tokio 1.x.

But any work on tokio-serial requires this issue to be fixed first.
What is blocking it considering that the "v4.0_serialstream" branch seems to work fine?

@ColinFinck
Copy link
Collaborator

I'll be using the https://github.com/berkowski/mio-serial/tree/v4.0_serialstream branch for mio-serial, and my newly added https://github.com/enlyze/tokio-serial/tree/v4.4.0_serialstream_multiplatform branch for tokio-serial now.
This works well for me under Windows and Linux.

Requires pinning branches/revisions in Cargo.toml as long as they are not merged to master and released on crates.io.
But other than that, I'm finally able to use serial ports with mio 0.7.x and tokio 1.x.

@berkowski
Copy link
Owner

Started #25 as a roadmap to winding this up ahead of maintenance/transfer of ownership.

@berkowski
Copy link
Owner

version 4.0.0-beta1 is on crates.io with mio 0.7 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants