Issue/55 - Make Query Class Extend-able #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a way to register new query processors, and provides a single place to provide context from the current query.
This provides a set of methods for each query processor to run that manipulate the query that is running.
This was intended to run these classes as single instances for the life of the query. This corrects that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is totally not event close to being finished, but I wanted to submit some of my initial thoughts about how this could be put together. This is mostly intended to spark discussion and thoughts about how it can be handled moving forward.
Basically, to register a custom query processor, you would extend
Query_Processor, and register that processor to the registry. This is currently done via a filter that runs each time the registry is constructed.The query class would then loop through the registered items while parsing important parts of the query, such as
select,where,join,group_by, etc.In this PR I have set up a rough idea on what I think
joinandwherecould be.This has not been tested in any fashion - just mostly focusing in on the "big conversations" about how the system could be structured.
Issue #55