Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macro): add babel-plugin-macros compatible macro #18

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

kentcdodds
Copy link
Collaborator

What: Create a macro for people to use in their projects

Why: It's a really handy tool!

How:

  • Extracted core logic after finding references to a separate file
  • Use that for the macro
  • Add an import for glamorous

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@codecov-io
Copy link

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      4    +3     
  Lines          64     72    +8     
  Branches       19     19           
=====================================
+ Hits           64     72    +8
Impacted Files Coverage Δ
src/macro.js 100% <100%> (ø)
src/index.js 100% <100%> (ø) ⬆️
src/handle-glamorous-references.js 100% <100%> (ø)
src/looks-like.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea6289...c51415c. Read the comment docs.

@kentcdodds kentcdodds merged commit c408be4 into master Jan 31, 2018
@kentcdodds kentcdodds deleted the pr/add-macro branch January 31, 2018 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants