When using :display_with shows text AND nil value. Only allows editing of nil value.

[betjaminrichards]

I have the following code:

<%= best_in_place_if can?(:update, risk), risk, :effect, :display_with => :simple_format, :path => assessment_risk_path(assessment,risk), type: :textarea, html_attrs: { "class" => "input-block-level" }, :nil => "Click to add a effect..." %>

What I get on screen is

Click to add a effect...

Sed ut perspiciatis unde omnis iste natus error sit voluptatem accusantium doloremque laudantium, totam rem aperiam,

eaque ipsa quae ab illo inventore veritatis et quasi architecto beatae vitae dicta sunt explicabo.

Nemo enim ipsam voluptatem quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione voluptatem sequi nesciunt. Neque porro quisquam est, qui dolorem ipsum quia dolor sit amet, consectetur, adipisci velit, sed quia non numquam eius modi tempora inci

The attribute's text is correctly formatted, but:

1. Why is it showing both the nil text AND the attribute's actual text?
2. I can only click and edit the "Click to add a effect..." text, not the actual attribute's text

Any ideas?

[sebastialonso]

Which version of Rails are you using?

[betjaminrichards]

Ruby: 2.0.0p353
Rails: 3.2.14

[osuthorpe]

I am getting the same error. When I use (display_with: :simple_format) I get both the nil text and the saved attribute

[timcase]

Changing the best_in_place helper method so that it wraps the markup it generates into a div instead of a span fixed this for me. I used :display_as with a textile field rendered as html, and I noticed that calling jQuery's html() method on a span with a

tag inside of it resulted in nil getting returned, which then got interpreted by BIP to display :nil. The jQuery html() nil is probably due to a

tag inside of a tag being regarded as invalid HTML 5.

[seuros]

Can you send a PR ?

[seuros]

@bensaufley , @pjmartorell, @vjt , @the-robear , @sao, @outomyelement : what do you thinkg about changing it to div ?

[bensaufley]

span and div have different uses – I'd be wary of making that change by default because people may be relying on inline content. I'm having trouble understanding @timcase's explanation because it looks like his comment got malformatted? Make sure to wrap html tags in ``: <p/>, for example. Is that what you were saying, @timcase? Wrapping a `

` in a `` is invalid HTML, yes.

What if we had an option for it? container: :div for example? Defaults to :span?

[seuros]

👍 for the container: :div.
I think the javascript will be compatible with this change.

We could also make it better by have the gem configurable

#initializers/best_in_place.rb
BestInplace.configure do |config|
   config.container = :div
end

[bensaufley]

That's a great idea. I can tackle the content_tag override, pretty easy, but I'm not sure where to put the config defaults etc? Haven't done a ton of gem work. This StackOverflow suggests there should be a self.configure somewhere to get your implementation working, and it doesn't look like that exists?

[seuros]

I can do the configure part. I will do it asap, since your task depend on mine. it will consist mostly in writing some specs.

What worry me about this gem, is the thread safety issue with display_* . I think we have to find another event if that break the api.

[seuros]

To reproduce the issue

• visit a page that has a field with display_with, display_as
• restart your app (in multi server setup, the load balancing can send you to another server)
• modify the field
• the display_* is not set.

[bensaufley]

But that's a known issue, right, even in master?

[seuros]

Yes, it was here since the introduction of display_as, 2 year ago. I noticed that while reading the code.

[bensaufley]

Yeah. So, definitely a concern but not something blocking from merging, fixing, updating other things.

[seuros]

Yep. we could do it in version 3.1

[timcase]

I tried to use display_as on an attribute in my model that contains Textile formatted html. Textile wraps all of it's content in p tags. P tags inside of a span is invalid HTML, span is an inline element and therefore you can't have block-level elements (such as a p, div, h1, table etc.), inside of a span. When best_in_place uses element.html(), it's receiving a nil because, I suspect, the invalid HTML is not available to the DOM and thus not available to be inspected by jQuery. On lines 42 and 75 of https://github.com/bernat/best_in_place/blob/master/lib/best_in_place/helper.rb, I changed the span to a div, because div's can hold other block-level elements.

I forked the repo and tried running the specs but I got lost at the part on cding into test_app. I couldn't find the test_app dir in the codebase so I have no idea if this breaks anything except to say that so far it's working quite dandy for me and I've already sent the change to my production environment.

[sao]

@bensaufley @seuros I agree on the content param 👍

[seuros]

I pushed the configure part

BestInPlace.container = :div

You can also use the block syntax when we will add other options.

We need test for the js.

[betjaminrichards]

Hi, is there any progress on this being fixed? i.e. Is it on the roadmap? The ability to be able to render carriage returns etc in textareas is a pretty common requirement I would imagine.

[stereodenis]

@seuros display_with (;