Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official CLI? #14

Open
bodiam opened this issue May 6, 2023 · 2 comments
Open

Official CLI? #14

bodiam opened this issue May 6, 2023 · 2 comments

Comments

@bodiam
Copy link

bodiam commented May 6, 2023

Hi Bernhard,

I've been following your efforts here for a bit, and I really like what you're doing with the datafaker-cli. I was wondering if you might be interested in making this an "official" part of Datafaker (eg, host it at the datafaker repo, become a possible contributor to Datafaker if you see options to make integration easier, etc?).

If not, no issue either, and if there's any way we can help, please reach out!

Cheers,
Erik

@bernhardhuber
Copy link
Owner

Hi Erik,

Thank you for your invitation. I'll consider contributing datafaker-cli to "official" datafaker repo.

About Contributing

  • I 'm just adding format parameters cli options in datafaker-cli, as eg sql table name is currently hard coded. I'd like to finish this feature and then I'll come back to you.

  • Another contributing idea: I was already thinking about translating releationship.yml to german

  • Another contributing idea: Reviewing xml, yml Transformer as their API is a bit different from the other transformer APIs

Some other ideas

  • A nice-to-have would be to have an overview of the state of tranlated en/*.yml per non en-language. This would help non en-users to understand what they might get using datafaker.

About me:

  • As I do this programming in my spare time, I don't have to much time.
  • I'm not that much confident about creating issues and merge requests yet

regards bernhard

@bodiam
Copy link
Author

bodiam commented May 8, 2023

Hi Bernhard,

No worries about the merge request, you can just push your code to the master branch if you'd feel more comfortable with that, I don't mind, or we walk you through our process (we use a very simple way: make branch, send PR, merge). It's one of the simplest forms for GitHub flows (besides directly pushing to the main/master branch). We can also keep it here for now, don't mind either, but we have a small team of 3-5 core members, we could help out if you want.

We never ask anyone do to do anything, we're all volunteers, it's a labour of love. If people want something, they can do it themselves (like here for example: datafaker-net/datafaker#821).

Translations would to German would be most welcome, and also it would indeed be good to see the state per language. I think the en language is absolutely leading, and I'd really have no idea what's missing from all the other languages. Probably a lot, and probably a lot could be generated using AI these days.

In any case, when you feel the CLI is in a state where you think it could be merged, either as a sub module or however you see fit, I'd love to see your work as part of Datafaker, and we're happy to help if you want us to help!

Cheers,

Erik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants