Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useful stability fix #4

Closed
duke4e opened this issue May 6, 2018 · 2 comments
Closed

Useful stability fix #4

duke4e opened this issue May 6, 2018 · 2 comments

Comments

@duke4e
Copy link

duke4e commented May 6, 2018

Hi,

I'm using your great library and it looks like that the data I'm getting from server can be incosistent, so if the server returns no data, the app crashes in "+ (nonnull instancetype)withData:(nullable NSData *)data".

I've made the simple fix for that issue and am sharing it here with you:
id object = [NSJSONSerialization JSONObjectWithData:data ? data : [NSData data] options:NSJSONReadingAllowFragments error:&error];

@bernikowich-cedoni
Copy link

@duke4e hello.
Sorry for the late response. Can you create PR please? It will be awesome.

@bernikovich
Copy link
Owner

bernikovich commented Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants