Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Unify the naming scheme in input manifest #563

Closed
2 tasks
MiroslavRepka opened this issue Feb 6, 2023 · 1 comment · Fixed by #601
Closed
2 tasks

Chore: Unify the naming scheme in input manifest #563

MiroslavRepka opened this issue Feb 6, 2023 · 1 comment · Fixed by #601
Assignees
@Despire
Labels
chore A chore is updating dependencies, etc; no significant code changes good first issue Good for newcomers groomed Task that everybody agrees to pass the gatekeeper

Comments

@MiroslavRepka
Copy link
Contributor

Description

This issue aims to unify the naming scheme in the input manifest. Currently, we use camelCase (nodePool, providerSpec), snake_case (server_type, disk_size) and kebab-case (targeted-k8s). We should really choose one and stick with it.

I propose using camelCase everywhere.

Exit criteria

  • New naming scheme was chosen and implemented to input manifest
  • Docs have been updated accordingly
@MiroslavRepka MiroslavRepka added the chore A chore is updating dependencies, etc; no significant code changes label Feb 6, 2023
@MarioUhrik
Copy link
Contributor

Since this is a breaking change, I'd like to prioritize this to get it done sooner rather than later

@Despire Despire added good first issue Good for newcomers groomed Task that everybody agrees to pass the gatekeeper labels Feb 10, 2023
@Despire Despire self-assigned this Feb 21, 2023
@Despire Despire mentioned this issue Feb 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Despire Despire

Labels
chore A chore is updating dependencies, etc; no significant code changes good first issue Good for newcomers groomed Task that everybody agrees to pass the gatekeeper
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unify manifest naming berops/claudie
3 participants
@Despire @MiroslavRepka @MarioUhrik