Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Deletion of config fails if builder crashes after deleting nodes. #588

Closed
Despire opened this issue Feb 17, 2023 · 1 comment
Closed

Bug: Deletion of config fails if builder crashes after deleting nodes. #588

Despire opened this issue Feb 17, 2023 · 1 comment
Assignees
@Despire
Labels
bug Something isn't working groomed Task that everybody agrees to pass the gatekeeper

Comments

@Despire
Copy link
Contributor

Despire commented Feb 17, 2023

Current Behaviour

If the builder service crashes after deleting nodes when It comes back online and starts restarts the workflow for deletion it wail fail.

Expected Behaviour

The actions should be idempotent, if the nodes were successfully deleted, subsequent deletion shouldn't end with an error.

Steps To Reproduce

  1. Delete a config to trigger the deletion process
  2. immediately after deleting the nodes kill the builder process/image
  3. Repeat the deletion workflow
  4. the builder now fails on deleting the nodes
@Despire Despire added the bug Something isn't working label Feb 17, 2023
@bernardhalas bernardhalas added the groomed Task that everybody agrees to pass the gatekeeper label Feb 17, 2023
@Despire Despire mentioned this issue May 5, 2023
Merged
@Despire Despire self-assigned this May 10, 2023
@Despire
Copy link
Contributor Author

Despire commented May 12, 2023

fixed by #728

@Despire Despire closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Despire Despire

Labels
bug Something isn't working groomed Task that everybody agrees to pass the gatekeeper
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bernardhalas @Despire