-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Create a random hash to a node name #85
Comments
Consider this approach for all providers (not just GCP). |
https://stackoverflow.com/questions/22892120/how-to-generate-a-random-string-of-a-fixed-length-in-go We can use this for generating |
The firewall name should be also unique.
I am adding two new exit criteria to this task:
@jaskeerat789 you will need to add these new hashes into our golang templates. If you need help with that feel free to call me. |
Cool, I'll resume from Monday, will let you know if I need any help. Thanks for the update. |
@jaskeerat789 Found another resource that needs to be unique: ssh key name on Hetzner
|
I think its is better to add the hash to all resources because it can be easy to debug things if the resources don't have same name even though uniqueness is not required. What are your thoughts ? @bernardhalas @samuelstolicny @borkaz |
I agree |
All conditions were met and the feature was successfully implemented in #107 |
Motivation:
Some providers require name uniqueness (for example GCP) for virtual machines and some other resources. In order to avoid this problem, we should generate a unique random hash for every config file.
Description:
Random hash should be generated before or as part of the
applyTerraform()
functionHash should be config file unique.
Exit criteria:
The text was updated successfully, but these errors were encountered: