Feature: Create a random hash to a node name

[samuelstolicny]

Motivation:

Some providers require name uniqueness (for example GCP) for virtual machines and some other resources. In order to avoid this problem, we should generate a unique random hash for every config file.

Description:

Random hash should be generated before or as part of the applyTerraform() function
Hash should be config file unique.

Exit criteria:

• Find out which resources need to be unique
• Generate and add random hash to every firewall
• Generate and add random hash to every node
• Generate and add random hash to every ssh_key (Hetzner)

[bernardhalas]

Consider this approach for all providers (not just GCP).

[jaskeerat789]

https://stackoverflow.com/questions/22892120/how-to-generate-a-random-string-of-a-fixed-length-in-go

We can use this for generating strings of length n to append it to the node name. We can also look into the uuid but as discussed in the grooming, the length of these uuid(32 byte) will be a bit too long for our use case.

[samuelstolicny]

The firewall name should be also unique.

Error: name is already used (uniqueness_error)
│
│   with hcloud_firewall.defaultfirewall,
│   on hetzner.tf line 10, in resource "hcloud_firewall" "defaultfirewall":
│   10: resource "hcloud_firewall" "defaultfirewall" {

I am adding two new exit criteria to this task:

• Find out which resources need to be unique (maybe network name in GCP)
• Generate and add random hash to every firewall

@jaskeerat789 you will need to add these new hashes into our golang templates. If you need help with that feel free to call me.

[jaskeerat789]

The firewall name should be also unique.

Error: name is already used (uniqueness_error)
│
│   with hcloud_firewall.defaultfirewall,
│   on hetzner.tf line 10, in resource "hcloud_firewall" "defaultfirewall":
│   10: resource "hcloud_firewall" "defaultfirewall" {

I am adding two new exit criteria to this task:

• Find out which resources need to be unique (maybe network name in GCP)
• Generate and add random hash to every firewall

@jaskeerat789 you will need to add these new hashes into our golang templates. If you need help with that feel free to call me.

Cool, I'll resume from Monday, will let you know if I need any help. Thanks for the update.

[samuelstolicny]

@jaskeerat789 Found another resource that needs to be unique: ssh key name on Hetzner

terraformer   | │ Error: SSH key name is already used (uniqueness_error)
terraformer   | │ 
terraformer   | │   with hcloud_ssh_key.platform,
terraformer   | │   on hetzner.tf line 56, in resource "hcloud_ssh_key" "platform":
terraformer   | │   56: resource "hcloud_ssh_key" "platform" {

[jaskeerat789]

I think its is better to add the hash to all resources because it can be easy to debug things if the resources don't have same name even though uniqueness is not required. What are your thoughts ? @bernardhalas @samuelstolicny @borkaz

[samuelstolicny]

I think its is better to add the hash to all resources because it can be easy to debug things if the resources don't have same name even though uniqueness is not required. What are your thoughts ? @bernardhalas @samuelstolicny @borkaz

I agree

[samuelstolicny]

All conditions were met and the feature was successfully implemented in #107