feat(devtool): disabled console log on android and added a mention to…

… the relevant issue on github
berty · Nov 24, 2018 · 5142616 · 5142616
1 parent 5e2d1ce
commit 5142616
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/client/react-native/android/ble/build.gradle b/client/react-native/android/ble/build.gradle
@@ -38,7 +38,7 @@ dependencies {
     testImplementation 'junit:junit:4.12'
     androidTestImplementation 'com.android.support.test:runner:1.0.2'
     androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'
-    implementation project(':core')
+implementation project(':core')
 }
 
 task deleteJar(type: Delete) {
@@ -52,4 +52,4 @@ task createJar(type: Copy) {
     rename('classes.jar', 'ble.jar')
 }
 
-createJar.dependsOn(deleteJar, build)
+createJar.dependsOn(deleteJar, build)
diff --git a/client/react-native/common/components/Screens/Settings/Devtools/List.js b/client/react-native/common/components/Screens/Settings/Devtools/List.js
@@ -228,11 +228,19 @@ export default class List extends PureComponent {
               }
             />
           )}
-          <Menu.Item
-            icon='file-text'
-            title='Console logs'
-            onPress={() => navigation.push('devtools/logs')}
-          />
+          {Platform.OS !== 'android' && (
+            <Menu.Item
+              icon='file-text'
+              title='Console logs'
+              onPress={() => navigation.push('devtools/logs')}
+            />
+          )}
+          {Platform.OS === 'android' && (
+            <Menu.Item
+              icon='file-text'
+              title='Console logs (crash on Android cf. #627)'
+            />
+          )}
         </Menu.Section>
         <Menu.Section>
           <Menu.Item