fix: prevent secrets from being resent

berty · Mar 4, 2020 · dd14569 · dd14569
1 parent 19c119c
commit dd14569
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/go/internal/orbitutil/store_metadata_index.go b/go/internal/orbitutil/store_metadata_index.go
@@ -165,10 +165,6 @@ func (m *metadataStoreIndex) handleGroupAddDeviceSecret(event proto.Message) err
 		return errcode.ErrDeserialization.Wrap(err)
 	}
 
-	if !destPK.Equals(m.ownMemberDevice.Member) {
-		return errcode.ErrGroupSecretOtherDestMember
-	}
-
 	senderPK, err := crypto.UnmarshalEd25519PublicKey(e.DevicePK)
 	if err != nil {
 		return errcode.ErrDeserialization.Wrap(err)
@@ -178,6 +174,10 @@ func (m *metadataStoreIndex) handleGroupAddDeviceSecret(event proto.Message) err
 		m.sentSecrets[string(e.DestMemberPK)] = struct{}{}
 	}
 
+	if !destPK.Equals(m.ownMemberDevice.Member) {
+		return errcode.ErrGroupSecretOtherDestMember
+	}
+
 	return nil
 }