fix: duplicated member entry #4691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuricmp
force-pushed
the
4687-anon-user-gets-added-to-every-group-made
branch
3 times, most recently
from
88016f6
to
b4d101c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4691 +/- ##
==========================================
- Coverage 31.47% 31.46% -0.02%
==========================================
Files 442 442
Lines 22945 22940 -5
Branches 1871 1870 -1
==========================================
- Hits 7223 7218 -5
Misses 15176 15176
Partials 546 546
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
iuricmp
force-pushed
the
4687-anon-user-gets-added-to-every-group-made
branch
from
b4d101c
to
faf4830
Compare
Fix for duplicate member in group members list. Signed-off-by: Iuri Pereira <iuricmp@gmail.com>
iuricmp
force-pushed
the
4687-anon-user-gets-added-to-every-group-made
branch
from
faf4830
to
341bb2d
Compare
|
🎉 This PR is included in version 2.468.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for duplicate member in group members list.
Disclaimer: This is a quick-fix solution. The proper solution came from understanding why
TypeMemberUpdatedevent is being dispatched twice for the current user in the StreamEvent.It is a Berty's Javascript issue since it's not reproducible on Berty's Mini.
Signed-off-by: Iuri Pereira iuricmp@gmail.com
fix #4687