Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disabling the "Submit a bug" button for now #4740

Conversation

iuricmp
Copy link
Contributor

@iuricmp iuricmp commented Aug 1, 2023

Disabling it until we have time to improve this feature.

Copy link
Collaborator

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me in the emulator.

@iuricmp iuricmp force-pushed the 4684-more-accurate-systeminfo-in-bug-report-message branch from 64cf9b0 to dde0a95 Compare August 1, 2023 11:40
Disabling it until we have time to improve this feature.

Signed-off-by: Iuri Pereira <iuricmp@gmail.com>
@iuricmp iuricmp force-pushed the 4684-more-accurate-systeminfo-in-bug-report-message branch from dde0a95 to 0fcebe8 Compare August 1, 2023 12:05
@iuricmp
Copy link
Contributor Author

iuricmp commented Aug 1, 2023

FYI: Lint was complaining about the unused translation string. So I removed them.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 45.26% and project coverage change: +0.01% 🎉

Comparison is base (2274407) 31.48% compared to head (0fcebe8) 31.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4740      +/-   ##
==========================================
+ Coverage   31.48%   31.49%   +0.01%     
==========================================
  Files         445      445              
  Lines       23495    23480      -15     
  Branches     1886     1883       -3     
==========================================
- Hits         7397     7395       -2     
+ Misses      15552    15539      -13     
  Partials      546      546              
Flag Coverage Δ
js.unittests 43.83% <45.26%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ges/screens/settings/SettingsHome/SettingsHome.tsx 46.90% <45.26%> (+3.93%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuricmp iuricmp merged commit 09f4cc6 into berty:master Aug 3, 2023
17 checks passed
@iuricmp iuricmp deleted the 4684-more-accurate-systeminfo-in-bug-report-message branch August 3, 2023 08:10
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

🎉 This PR is included in version 2.469.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants