Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new screen for Open Source license #4747

Merged

Conversation

iuricmp
Copy link
Contributor

@iuricmp iuricmp commented Aug 18, 2023

Adds a new screen to render the Open Source license disclaimer directly from GitHub raw page.

fix #4257

Adds a new screen to render the Open Source license disclaimer directly from github raw page.

Signed-off-by: Iuri Pereira <iuricmp@gmail.com>
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.01% 🎉

Comparison is base (29bcd2d) 31.49% compared to head (e08d550) 31.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4747      +/-   ##
==========================================
+ Coverage   31.49%   31.50%   +0.01%     
==========================================
  Files         445      446       +1     
  Lines       23480    23485       +5     
  Branches     1883     1883              
==========================================
+ Hits         7395     7399       +4     
- Misses      15539    15540       +1     
  Partials      546      546              
Flag Coverage Δ
js.unittests 43.86% <80.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
js/packages/navigation/stacks.tsx 14.70% <ø> (ø)
...ackages/screens/settings/AboutBerty/AboutBerty.tsx 60.00% <0.00%> (-6.67%) ⬇️
...kages/screens/settings/CodeLicense/CodeLicense.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on iOS and Android.

@iuricmp iuricmp merged commit 59f1035 into berty:master Aug 18, 2023
17 checks passed
@iuricmp iuricmp deleted the 4257-user-is-unable-to-open-open-source-licenses branch August 18, 2023 10:29
@github-actions
Copy link

🎉 This PR is included in version 2.469.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User is unable to open Open source licenses
2 participants