Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null check #4811

Merged
merged 1 commit into from Mar 4, 2024
Merged

fix: null check #4811

merged 1 commit into from Mar 4, 2024

Conversation

iuricmp
Copy link
Contributor

@iuricmp iuricmp commented Mar 1, 2024

This PR fix the CI issue on #4809

Signed-off-by: Iuri Pereira iuricmp@gmail.com

Signed-off-by: Iuri Pereira <iuricmp@gmail.com>
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 31.47%. Comparing base (edf8867) to head (a6a22d5).

Files Patch % Lines
...kages/screens/settings/ThemeEditor/ThemeEditor.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4811   +/-   ##
=======================================
  Coverage   31.47%   31.47%           
=======================================
  Files         446      446           
  Lines       23516    23516           
  Branches     1883     1883           
=======================================
  Hits         7401     7401           
  Misses      15570    15570           
  Partials      545      545           
Flag Coverage Δ
js.unittests 43.86% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuricmp iuricmp merged commit 5810400 into berty:master Mar 4, 2024
18 checks passed
@iuricmp iuricmp deleted the fix/null-check-js branch March 4, 2024 09:05
Copy link

github-actions bot commented Mar 4, 2024

🎉 This PR is included in version 2.469.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants