Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift3 and Xcode8? #9

Closed
chriscohoat opened this issue Sep 15, 2016 · 4 comments
Closed

Swift3 and Xcode8? #9

chriscohoat opened this issue Sep 15, 2016 · 4 comments

Comments

@chriscohoat
Copy link

Thanks for the awesome library! I'm having build errors with Swift3 and Xcode8 while using either the swift3 branch or master branch.

I'm using:

pod 'CustomizableActionSheet', :git => 'https://github.com/beryu/CustomizableActionSheet', :branch => 'swift3'

And have a number of build errors. I noticed #8 is open but neither branches seem to work for my project.

Any suggestions?

@beryu
Copy link
Owner

beryu commented Sep 16, 2016

Thank you for reporting!
I can't check detail at now, but I will try within 24 hours.
(Because of my hard work, sorry.)

@beryu
Copy link
Owner

beryu commented Sep 16, 2016

@chriscohoat
Sorry for my mistake.

I forgot to save new file under "Source" directory.
Error was occurred by building with Swift2.2 style file by CocoaPods.

I committed Swift3 style file to correct directory, and now we can build with Swift3 in case of installed via CocoaPods!
I applied this change to master. So just write Podfile like below:

pod 'CustomizableActionSheet'

Please check it.

@chriscohoat
Copy link
Author

Thanks for your hard work @beryu! It works great. 1.0.6 indeed works perfectly with Xcode 8 and Swift 3. Appreciate it.

@beryu
Copy link
Owner

beryu commented Sep 16, 2016

Thank you for your review!
I will close this issue.

@beryu beryu closed this as completed Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants