Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some bugs & suggestions #2

Closed
nay-seven opened this issue Jan 31, 2020 · 6 comments
Closed

some bugs & suggestions #2

nay-seven opened this issue Jan 31, 2020 · 6 comments

Comments

@nay-seven
Copy link

nay-seven commented Jan 31, 2020 •
edited

Hello ,
Congrats and thanks for this release,
some bug i've notice:

  • for the MIDI circle sequencer, i suppose there's missing note off, cause after first sequence no note are send, maybe not all VST need this , but at least some?
    so i found a workaround with adding a curve looper to the range of a note wrap ( see attachement)
  • When i reload this patch, the point in the circle seq are not present anymore
  • a suggestion, space bar to active/stop audio engine could be cool ?

Thanks for reading

( btw, don't know if you use social networks, but I've share your work on our Facebook group about experimental tool

bug midi
@awwbees
Copy link
Collaborator

awwbees commented Jan 31, 2020

thank you for taking the time to check out bespoke!

yes, there are indeed a number of bugs, particularly around reloading save states not properly restoring everything. my cop-out answer for now is "embrace the ephemerality of your patches, because maybe they won't come back when you reload them!"

I have only used the circlesequencer in conjunction with my drumplayer module, which doesn't care about note-offs, so you're right on the money there. a better way for you to hack the circlesequencer to do note-offs would be to route it into the notesustain module, which will do a note-off after a specified length of time.

I can't seem to access that link on facebook, perhaps the group is private.

@nay-seven
Copy link
Author

i agree with your ephemerality philosophy ;-)
Thanks for the notesustain tips, works fine.
And you're right about the group, i can invite you if needed ;-)

@awwbees
Copy link
Collaborator

awwbees commented Feb 1, 2020

sure thing! I don't use facebook much, but I will take a peek in that group. my facebook account is facebook.com/awwbees for the invite

@nay-seven
Copy link
Author

nay-seven commented Feb 1, 2020 •
edited

i've send you an invitation as friend cause i can't invite you in the group if you're not,
facebook.....;-)
or i suppose you can use the "ask to join the groupe" ?

awwbees pushed a commit that referenced this issue Feb 19, 2020
@KottV
Merge pull request #2 from awwbees/master
a2e7e62 
uptade
djdeath added a commit to djdeath/BespokeSynth that referenced this issue Aug 25, 2020
@djdeath
Fix ASAN warning
d87fb6e 
==498254==ERROR: AddressSanitizer: strncpy-param-overlap: memory ranges [0x629000019ae8,0x629000019afa) and [0x629000019ae8, 0x629000019afa) overlap
    #0 0x555555eb74e6 in __interceptor_strncpy (BespokeSynth/Builds/LinuxMakefile/build/BespokeSynth+0x9634e6)
    BespokeSynth#1 0x555557032899 in StringCopy(char*, char const*, int) ../../Source/SynthGlobals.cpp:474
    BespokeSynth#2 0x555556f13963 in MidiDevice::ConnectInput(char const*) ../../Source/MidiDevice.cpp:39
@asmw
Copy link
Collaborator

asmw commented Nov 2, 2021

@nay-seven are all of these still issues? If so, could you please open individual issues for bugs + feature wishes, that is easier to track

@awwbees
Copy link
Collaborator

awwbees commented Nov 5, 2021

ah yes I think these are all fixed now

@awwbees awwbees closed this as completed Nov 5, 2021
@awwbees awwbees mentioned this issue Oct 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@awwbees @asmw @nay-seven