Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable annotations are ignored #1

Closed
sobolevn opened this issue Feb 26, 2019 · 2 comments
Closed

Variable annotations are ignored #1

sobolevn opened this issue Feb 26, 2019 · 2 comments

Comments

@sobolevn
Copy link

Here you only check function annotations: https://github.com/best-doctor/flake8-annotations-complexity/blob/master/flake8_annotations_complexity/ast_helpres.py#L17-L20

However, it is still possible to use really complex variable annotations:

some_value: List[Union[List[str], Dict[str, Dict[str, str]]]] = ...
@sobolevn sobolevn mentioned this issue Feb 26, 2019
Closed
@Melevir
Copy link
Contributor

Melevir commented Feb 26, 2019

Solved in 451ef83

@Melevir Melevir closed this as completed Feb 26, 2019
@sobolevn
Copy link
Author

@Melevir awesome! Can you please release a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Melevir @sobolevn