Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output_generator: markdown-gallery not work in best-of-update-action version 0.8.5 #59

Open
jiandongj opened this issue Jan 27, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@jiandongj
Copy link

Describe the bug:

output_generator: markdown-gallery not work in current version (0.8.5).

Expected behaviour:

output_generator should support "markdown-gallery", not only "markdown-list" in this configuration: https://github.com/best-of-lists/best-of-generator#configuration-options

Steps to reproduce the issue:

Follow best-of-streamlit repo's projects.yml, and update github workflow best-of-update-action to version 0.8.5, when trigger action this bug happend.

Technical details:

  • Host Machine OS (Windows/Linux/Mac):

Possible Fix:

Additional context:

markdown-gallery feature was introduced by this pr: #29

@jiandongj jiandongj added the bug Something isn't working label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant