Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decodeFile can not handle relative symlinks #4

Closed
png6ud opened this issue Dec 16, 2022 · 2 comments
Closed

decodeFile can not handle relative symlinks #4

png6ud opened this issue Dec 16, 2022 · 2 comments

Comments

@png6ud
Copy link

png6ud commented Dec 16, 2022

After last update, it seems like decodeFile no longer can handle symlinks with relative linking. We get ".. does not point to a file" even though the jsoni file (which is a symlink) do point to a file when trying to cat the path in the error message. My guess is that there is something wrong with
if ($fileInfo->isLink() && $linkTarget = $fileInfo->getLinkTarget()) { $fileInfo = new SplFileInfo($linkTarget); }

This section of the code. It seems like the old version of the code could handle relative symlink paths, but the new version can not.

@jeromegamez
Copy link
Member

Thanks for letting me know, I'll look right into it!

@jeromegamez
Copy link
Member

Could you please check if #5 works for you? I added a test and am confident it works, but better be sure than sorry 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants