Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Samsung S4 stock browser incorrectly(?) labelled as Chrome Mobile #29

Closed
clark-pan opened this issue Sep 20, 2013 · 2 comments
Closed
Labels

Comments

@clark-pan
Copy link

Samsung's S4's stock browser is possibly being incorrectly labelled as 'Chrome Mobile', version "1.0".

Heres the platform object as json:

{
    "version" : "1.0",
    "name" : "Chrome Mobile",
    "os" : {
        "architecture" : 32,
        "family" : "Android",
        "version" : "4.2.2"
    },
    "description" : "Chrome Mobile 1.0 on Samsung (Android 4.2.2)",
    "layout" : "WebKit",
    "manufacturer" : "Samsung",
    "prerelease" : null,
    "product" : "Samsung",
    "ua" : "Mozilla/5.0 (Linux; Android 4.2.2; en-au; SAMSUNG GT-I9500 Build/JDQ39) AppleWebKit/535.19 (KHTML, like Gecko) Version/1.0 Chrome/18.0.1025.308 Mobie Safari/535.19"
}

Now what i think the issue is that, the new S4 stock browser is actually using a bastardized version of Chrome Mobile, but locked at version 18.0.1025.308. They've also included their own "Version" which in platform's logic makes it think it is Chrome Mobile Version 1 (doesn't exist)

I'm unsure of how to fix this though; Should we label this version of Samsung Galaxy s4 as the 'stock browser' or should we correct the Chrome Mobile version detection logic to label it correctly as Chrome Mobile 18.

Any thoughts/advice?

@bnjmnt4n
Copy link
Member

Can you test this with the latest edge version of platform.js?

@bnjmnt4n
Copy link
Member

I'm not getting this issue anymore. platform.description now is 'Android Browser 1.0 (like Chrome 18.0.1025.308) on Samsung Galaxy S4 (Android 4.2.2)'.

@jdalton jdalton added the bug label Feb 12, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

3 participants