Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

FeatureDataCollector should not be registered in kernel debug mode #95

Open
ndench opened this issue Apr 29, 2022 · 3 comments
Open

FeatureDataCollector should not be registered in kernel debug mode #95

ndench opened this issue Apr 29, 2022 · 3 comments

Comments

@ndench
Copy link

ndench commented Apr 29, 2022

After upgrading to version 4.3 which hides the TraceableDataCollector when APP_DEBUG=0 (#89), I now get the following error when running tests with debug mode disabled:

TypeError: Flagception\Bundle\FlagceptionBundle\Profiler\FeatureDataCollector::__construct(): Argument #1 ($chainActivator) must be of type Flagception\Bundle\FlagceptionBundle\Activator\TraceableChainActivator, Flagception\Activator\ChainActivator given

I think that maybe the FeatureDataCollector should not be registered when debug mode is disabled? Or perhaps it just needs the data_collector tag removed?

@yakobe
Copy link

yakobe commented Sep 1, 2022

Is there any work around for this error? At the moment it seems i cannot turn debug mode off 😕

@ndench
Copy link
Author

ndench commented Sep 2, 2022

I haven't found one. Although I'll admit I haven't looked very hard either. I just locked to a previous version.

I'm happy to submit a PR to fix it if someone can point me in the right direction.

@vitsadecky
Copy link

vitsadecky commented Nov 22, 2022

Hi.

temporary solution is forced service registration: Flagception\Bundle\FlagceptionBundle\Activator\TraceableChainActivator

flagception.activator.chain_activator:
      class: Flagception\Bundle\FlagceptionBundle\Activator\TraceableChainActivator

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants