Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajout des invitations envoyées dans la page collaborateurs #520

Merged
merged 3 commits into from
May 29, 2024

Conversation

ddahan
Copy link
Contributor

@ddahan ddahan commented May 24, 2024

Fait

  • Ajout des invitations envoyées dans la page collaborateurs
  • Tests unitaires liés
  • Création d'un component générique qui isole la logique template d'affichage d'une solicitation pour être DRY

close #512

Screenshot

sentinvit

@ddahan ddahan marked this pull request as ready for review May 24, 2024 14:33
@ddahan ddahan requested review from pletelli and alemangui May 24, 2024 14:34
@alemangui
Copy link
Collaborator

Je trouve cette view tellement stylée


User = get_user_model()


class CollaborationInvitationListView(ListAPIView):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que ça vaut la peine d'ajouter une permission IsAuthenticated ? Ça permettrait de renvoyer un 403 et non pas un 404 pour le cas où l'on n'est pas auth.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui tout à fait, merci, ajouté (en plus ça renvoyait même pas un 404 mais un 500 haha)

@alemangui alemangui merged commit a2cec94 into staging May 29, 2024
5 checks passed
@alemangui alemangui deleted the sentinvit branch May 29, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gestion des collaborateurs - ajouter la liste des invités en cours
2 participants