Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions CI #5919

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Add github actions CI #5919

merged 2 commits into from
Feb 23, 2021

Conversation

tchak
Copy link
Member

@tchak tchak commented Feb 17, 2021

No description provided.

@tchak tchak force-pushed the gh-actions branch 8 times, most recently from 7155788 to bc84f52 Compare February 18, 2021 08:54
Copy link
Contributor

@kemenaran kemenaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sur le principe ça me va.

Après j'hésite toujours à juste raquer pour CircleCI pour revenir à des temps de test raisonnables. Mais bon, Github Actions ça peut pas faire de mal (on peut même garder circle pendant ce temps, et tester.)

.github/workflows/ci.yml Show resolved Hide resolved
@kemenaran
Copy link
Contributor

Et aussi on se demandait ce qui prenait 10mn dans les test de contrôleurs.

J'ai lancé un bin/rspec spec/controllers --profile 10, et ça dit que c'est les tests GraphQL (et d'API en général) qui sont très lent. Genre 5 secondes par test.

Top 10 slowest examples (55.33 seconds, 10.0% of total time):
  Manager::AdministrateursController#show with 2FA enabled is expected to include "admin1@admin.com"
    20.82 seconds ./spec/controllers/manager/administrateurs_controller_spec.rb:25
  API::V2::GraphqlController when authenticated dossier with individual should be returned
    4.9 seconds ./spec/controllers/api/v2/graphql_controller_spec.rb:315
  API::V2::GraphqlController when not authenticated should return error
    4.46 seconds ./spec/controllers/api/v2/graphql_controller_spec.rb:1359
  API::V2::GraphqlController when authenticated mutations dossierChangerGroupeInstructeur validation error
    4.06 seconds ./spec/controllers/api/v2/graphql_controller_spec.rb:1047
  API::V2::GraphqlController when not authenticated dossier should return error
    3.73 seconds ./spec/controllers/api/v2/graphql_controller_spec.rb:1367
  API::V2::GraphqlController when authenticated mutations dossierChangerGroupeInstructeur should changer groupe instructeur change made
    3.58 seconds ./spec/controllers/api/v2/graphql_controller_spec.rb:1070
  API::V2::GraphqlController when authenticated demarche filter archived dossiers with archived=false only not archived dossiers should be returned
    3.53 seconds ./spec/controllers/api/v2/graphql_controller_spec.rb:225
  API::V2::GraphqlController when authenticated groupeInstructeur should be returned
    3.49 seconds ./spec/controllers/api/v2/graphql_controller_spec.rb:608
  API::V2::GraphqlController when not authenticated mutation should return error
    3.45 seconds ./spec/controllers/api/v2/graphql_controller_spec.rb:1388
  API::V2::GraphqlController when authenticated mutations dossierModifierAnnotation yes_no success when true should be a success
    3.33 seconds ./spec/controllers/api/v2/graphql_controller_spec.rb:1228

Top 10 slowest example groups:
  Manager::AdministrateursController
    2.96 seconds average (23.67 seconds / 8 examples) ./spec/controllers/manager/administrateurs_controller_spec.rb:1
  API::V2::GraphqlController
    2.75 seconds average (115.59 seconds / 42 examples) ./spec/controllers/api/v2/graphql_controller_spec.rb:1
  API::V1::ProceduresController
    1.09 seconds average (28.41 seconds / 26 examples) ./spec/controllers/api/v1/procedures_controller_spec.rb:1
  API::V1::DossiersController
    0.8223 seconds average (68.25 seconds / 83 examples) ./spec/controllers/api/v1/dossiers_controller_spec.rb:1
  StatsController
    0.70204 seconds average (7.02 seconds / 10 examples) ./spec/controllers/stats_controller_spec.rb:1
  AttachmentsController
    0.62603 seconds average (6.89 seconds / 11 examples) ./spec/controllers/attachments_controller_spec.rb:1
  Users::PasswordsController
    0.58031 seconds average (1.16 seconds / 2 examples) ./spec/controllers/users/passwords_controller_spec.rb:1
  APIController
    0.54633 seconds average (2.19 seconds / 4 examples) ./spec/controllers/api_controller_spec.rb:1
  Instructeurs::ProceduresController
    0.48959 seconds average (53.86 seconds / 110 examples) ./spec/controllers/instructeurs/procedures_controller_spec.rb:1
  Instructeurs::GroupeInstructeursController
    0.45513 seconds average (7.74 seconds / 17 examples) ./spec/controllers/instructeurs/groupe_instructeurs_controller_spec.rb:1

@tchak
Copy link
Member Author

tchak commented Feb 23, 2021

Merci d'avoir creusé ! Je vais regarder les spec GraphQL à l'occasion.

@tchak tchak force-pushed the gh-actions branch 2 times, most recently from ae29483 to 25ed8a0 Compare February 23, 2021 08:38
@tchak tchak merged commit e920764 into demarches-simplifiees:main Feb 23, 2021
@tchak tchak deleted the gh-actions branch February 23, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants