ETQ Admin, je peux ajouter/supprimer des experts notifiables #6041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kara22
changed the title
kemenaran
reviewed
Mar 30, 2021
app/views/new_administrateur/procedures/invited_expert_list.html.haml
Outdated
Show resolved
Hide resolved
app/views/new_administrateur/procedures/invited_expert_list.html.haml
Outdated
Show resolved
Hide resolved
app/views/new_administrateur/procedures/invited_expert_list.html.haml
Outdated
Show resolved
Hide resolved
spec/controllers/new_administrateur/procedures_controller_spec.rb
Outdated
Show resolved
Hide resolved
tchak
reviewed
Mar 31, 2021
tchak
reviewed
Mar 31, 2021
tchak
reviewed
Mar 31, 2021
tchak
reviewed
Mar 31, 2021
tchak
reviewed
Mar 31, 2021
tchak
reviewed
Mar 31, 2021
tchak
reviewed
Mar 31, 2021
kara22
force-pushed
the
feat/5813
branch
6 times, most recently
from
358aa08
to
ebacc87
Compare
kemenaran
reviewed
Apr 1, 2021
| @@ -206,7 +208,7 @@ def log_out | |||
| end | |||
|
|
|||
| def ask_confidential_avis(to, introduction) | |||
| fill_in 'avis_emails', with: to | |||
| page.execute_script("document.querySelector('#avis_emails').value = '#{to}'") | |||
There was a problem hiding this comment.
@krichtof tu avais eu besoin de faire ça, toi, pour que les tests utilisent le ComboMultipleDropdownList ?
There was a problem hiding this comment.
J'ai même fait pire, pour arriver à faire passer un test :
# hack because for unknown reason, the click on input doesn't show combobox-popover with selenium driver
script = "document.evaluate(\"//input[@aria-label='#{champ}']//ancestor::div[@data-reach-combobox]/div[@data-reach-combobox-popover]\", document, null, XPathResult.UNORDERED_NODE_ITERATOR_TYPE, null).iterateNext().removeAttribute(\"hidden\")"
execute_script(script)
C'est par ici : https://github.com/betagouv/demarches-simplifiees.fr/blob/6845aa69f16ebcc2212b32631183de7665813a5d/spec/support/feature_helpers.rb#L111
There was a problem hiding this comment.
Hooo, je vois :)
Ok, donc ici on peut utiliser ton helper select_multi, si je comprends bien.
|
@kemenaran c'est good j'ai ajouté le |
tchak
reviewed
Apr 2, 2021
app/controllers/new_administrateur/experts_procedures_controller.rb
Outdated
Show resolved
Hide resolved
tchak
reviewed
Apr 2, 2021
kemenaran
approved these changes
Apr 6, 2021
spec/controllers/new_administrateur/experts_procedures_controller_spec.rb
Outdated
Show resolved
Hide resolved
kara22
force-pushed
the
feat/5813
branch
2 times, most recently
from
ac85441
to
8bab293
Compare
This was
linked to
issues
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5813
La vue administrateur lorsque le feature flag est activé
Flag désactivé : l'instructeur peut demander l'avis aux experts de son choix
Flag activé : l'instructeur peut demander l'avis uniquement aux experts de la liste de l'administrateur
Important : Si le flag est activé, un expert ne peut pas demander l'avis d'un autre expert.