2021-05-07-01 #6185
Merged
2021-05-07-01 #6185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Rails i18n guide, enum values should be localized as `<model>/<enum>`, not as sub-values to the attribute. This fixes an exception in administrate when displaying a Dossier in the Manager. Note: we need to change the way GraphQL attributes are generated, because `AASM::Core::State#display_name` doesn’t honor the `model/attribute.value` convention (and instead tries to localize as `model.attribute/value`). So instead we lookup the localized name using ActiveRecord.
In the previous commit, we cleaned up the localization of the Dossier.state enum. This prevented administrate from crashing, but now the dossier enum are no longer localized in the Manager. By using a `Field::Enum` type, we instruct the administrate plugin to look up our localized name for the Dossier state enum.
SuperAdmin : correction de l'affichage de la page `/manager/dossiers`
Suppression des tâches de déploiement `after_party` les plus anciennes (#6177)
Use explicit name to avoid unknown constant errors
update administrate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Améliorations et correctifs
Technique
/manager/dossiersafter_partyles plus anciennes (tasks: remove older after_party tasks #6177)