Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifier les informations personnelles: utilisation de la clef primaire du candidat au lieu de celle de la candidature #2560

Merged
merged 1 commit into from May 30, 2023

Conversation

xavfernandez
Copy link
Contributor

Pourquoi ?

Cela facilitera la réutilisation du template apply/includes/job_seeker_info.html pour le parcours de "Déclaration d'embauche" où l'on ne dispose pas de candidature (créée uniquement à la fin du parcours)

Copy link
Contributor

@francoisfreitag francoisfreitag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

itou/templates/apply/includes/job_seeker_info.html Outdated Show resolved Hide resolved
itou/www/approvals_views/tests/test_detail.py Outdated Show resolved Hide resolved
itou/www/dashboard/tests.py Outdated Show resolved Hide resolved
instead of a job application

This will ease the reuse of apply/includes/job_seeker_info.html template
in the direct hire process (without job application).
@xavfernandez xavfernandez force-pushed the xfernandez/edit_job_seeker_info branch from 1705b0f to 1c63dd9 Compare May 26, 2023 07:52
Copy link
Contributor

@rsebille rsebille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est quand même beaucoup plus logique qu'un edit_job_seeker_info se base sur un candidat plutôt qu'une candidature 😅.

@xavfernandez xavfernandez added this pull request to the merge queue May 30, 2023
Merged via the queue into master with commit c33e663 May 30, 2023
4 checks passed
@xavfernandez xavfernandez deleted the xfernandez/edit_job_seeker_info branch May 30, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants