Feat/create json files from baserows #821
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvalentin
requested changes
Jun 26, 2024
| console.log(`Baserow Data sucessfully downloaded.\nStarting to validate the project data and generating the project JSON.`) | ||
| this._validateData(projects) | ||
| this._writeJson(projects) | ||
| return |
There was a problem hiding this comment.
note: je vais ajouter une règle de saut de ligne avant return
There was a problem hiding this comment.
j'ai ajouté des sauts de ligne mais je ne suis pas sur de la où il faut en mettre exactement.
Ex :
private async _delay(ms: number): Promise<void> {
return new Promise((resolve) => setTimeout(resolve, ms))
}
vs
private async _delay(ms: number): Promise<void> {
console.log(xxx)
return new Promise((resolve) => setTimeout(resolve, ms))
}
ou
private async _delay(ms: number): Promise<void> {
console.log(xxx)
return new Promise((resolve) => setTimeout(resolve, ms))
}
| } | ||
|
|
||
| private _validateThemes(project: RawProject) { | ||
| project.themes.forEach((themeId) => { |
There was a problem hiding this comment.
suggestion: sur les trois méthodes _validateThemes, _validateLinkedProjects et _validatePrograms, on pourrait passer directement les valeurs utiliser dans le foreach
ex:
this._validateThemes(project.themes)
...
private _validateThemes(themes: string[]) {
...There was a problem hiding this comment.
Je pensais aussi mais comme on fait d'abord tous les téléchargements puis toutes les validations, il y a besoin de donner tout le projet en paramètre pour pouvoir afficher son titre et son id en cas de problème.
…ould be discussed; contains a circular dependency warning !
ttdm
force-pushed
the
feat/create_JSON_files_from_baserows
branch
from
be00180
to
46b4768
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature principale : Génération des fichier projets pour le front (json + images)
Features secondaire / détails d'implem :
Autre notes : les mocks data n'étaient pour l'instant pas dans la feature branche. Je les ai donc ajoutées.
close #796
close #803
close #804
close #805