This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
(PC-1587) Init import Titelive Things #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnoo
approved these changes
Mar 18, 2019
| if self.infos['url_extrait_pdf'] != '': | ||
| thing.mediaUrls.append(self.infos['url_extrait_pdf']) | ||
|
|
||
| def get_extraData_from_infos(self): |
There was a problem hiding this comment.
Pour le coup ça aurait été bien de le factoriser quelque part, lui, non ? car c'est tout le meme que l'autre je suppose ?
|
|
||
| return extraData | ||
|
|
||
| def get_infos_from_data_line(self, elts: []): |
There was a problem hiding this comment.
meme si ce fichier en particulier ne va servir qu'une fois a priori, les gens ne le sauront pas forcément s'ils doivent faire des mises à jour
| return data_lines | ||
|
|
||
|
|
||
| def get_thing_type_and_extra_data_from_titelive_type(titelive_type): |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.