This repository has been archived by the owner on Mar 10, 2022. It is now read-only.
(PC-11116): Allow pro user with no structures to reach refunds page #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asagot-ansa
force-pushed
the
pc-11116-no-results-page-refunds
branch
from
31c4fdb
to
66e2e7d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1523 +/- ##
==========================================
+ Coverage 87.87% 87.88% +0.01%
==========================================
Files 377 377
Lines 6400 6406 +6
Branches 1745 1750 +5
==========================================
+ Hits 5624 5630 +6
Misses 748 748
Partials 28 28
Continue to review full report at Codecov.
|
asagot-ansa
force-pushed
the
pc-11116-no-results-page-refunds
branch
from
66e2e7d
to
698cc4c
Compare
gael-boyenval
approved these changes
Oct 14, 2021
Comment on lines
133
to
142
| {isLoading ? ( | ||
| <Spinner /> | ||
| ) : ( | ||
| venuesOptions.length ? ( | ||
| <> | ||
| <p> | ||
| Les remboursements s’effectuent tous les 15 jours, rétroactivement suite à la validation | ||
| d’une contremarque dans le guichet ou à la validation automatique des contremarques | ||
| d’évènements. Cette page est automatiquement mise à jour à chaque remboursement. | ||
| </p> |
There was a problem hiding this comment.
Je pense que c'est pas mal tant que possible d'éviter les if imbriqués, surtout quand l'enfant est aussi long (arrivé en bas de la lecture du composant, on a oublié dans quel test on se trouve)
pour la lecture, peut-être un truc comme :
Suggested change
| {isLoading ? ( | |
| <Spinner /> | |
| ) : ( | |
| venuesOptions.length ? ( | |
| <> | |
| <p> | |
| Les remboursements s’effectuent tous les 15 jours, rétroactivement suite à la validation | |
| d’une contremarque dans le guichet ou à la validation automatique des contremarques | |
| d’évènements. Cette page est automatiquement mise à jour à chaque remboursement. | |
| </p> | |
| { isLoading && <Spinner /> } | |
| { hasNoResults && (...no result message) } | |
| { hasResults && (le form) } |
et une définition plus haut
const hasNoResults = !isLoading && !venuesOptions.length
const hasResults = !isLoading && !!venuesOptions.length // ou venuesOptions.length > 0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout d'une vérification sur la possibilité d'avoir une liste de venues vide renvoyées par l'API quand l'utilisateur n'a pas de structures rattachées; auquel cas on affiche un message d'informations plutôt qu'avoir un loader infini.