This repository has been archived by the owner on Mar 10, 2022. It is now read-only.
(PC-1707) fix stocks manager form with react final form #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ledoux
force-pushed
the
pc-1707-react-final-form-stocks-manager
branch
from
b6b133c
to
a53e700
Compare
Ledoux
changed the title
Ledoux
force-pushed
the
pc-1707-react-final-form-stocks-manager
branch
4 times, most recently
from
3279024
to
794c1d5
Compare
Ledoux
changed the title
Ledoux
force-pushed
the
pc-1707-react-final-form-stocks-manager
branch
18 times, most recently
from
f6e8716
to
1bcc280
Compare
Ledoux
force-pushed
the
pc-1707-react-final-form-stocks-manager
branch
3 times, most recently
from
5cfdf20
to
1173368
Compare
Ledoux
force-pushed
the
pc-1707-react-final-form-stocks-manager
branch
4 times, most recently
from
53ea609
to
172b89a
Compare
Ledoux
force-pushed
the
pc-1707-react-final-form-stocks-manager
branch
from
3275c75
to
f2b8013
Compare
sixertoy
reviewed
Apr 8, 2019
sixertoy
reviewed
Apr 8, 2019
src/components/pages/Offer/StocksManager/StockItem/EventOrThingFields.jsx
Outdated
Show resolved
Hide resolved
sixertoy
reviewed
Apr 8, 2019
sixertoy
reviewed
Apr 8, 2019
src/components/pages/Offer/StocksManager/StockItem/RawStockItem.jsx
Outdated
Show resolved
Hide resolved
.../pages/Offer/StocksManager/StockItem/selectFormInitialValuesByStockAndOfferIdAndOffererId.js
Outdated
Show resolved
Hide resolved
.../pages/Offer/StocksManager/StockItem/selectFormInitialValuesByStockAndOfferIdAndOffererId.js
Outdated
Show resolved
Hide resolved
sixertoy
reviewed
Apr 8, 2019
sixertoy
approved these changes
Apr 8, 2019
sixertoy
suggested changes
Apr 8, 2019
Ledoux
force-pushed
the
pc-1707-react-final-form-stocks-manager
branch
from
4e98943
to
bb402fc
Compare
sixertoy
approved these changes
Apr 8, 2019
Ledoux
force-pushed
the
pc-1707-react-final-form-stocks-manager
branch
3 times, most recently
from
166e2ad
to
d352672
Compare
Ledoux
force-pushed
the
pc-1707-react-final-form-stocks-manager
branch
from
d352672
to
a728f80
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pour enlever le hack du recursiveMap, dans tous les components enfants de Form(shared) (qui decoulait de (PC-1647) parse form child betagouv/pass-culture-shared#92 obligé pour faire la pr du merge event occurrence sur stock): comme là par exemple
https://github.com/betagouv/pass-culture-pro/blob/master/src/components/pages/Offer/StocksManager/StockItem/EventFields.jsx#L84
Pour réparer grace aux decorators et aux Fields plus compréhensibles de react final form:
l'edition du champ number prix qui voulait pas qu'on lui enleve le zero, meme en voulant le deleter:
l'edition de la endTime qui se refrachit pas parfois meme quand on tape des nombres:
Empêcher la fusion du beginTime avec le endTime quand on change le beginningDateTime:
l'edition de la endDateTime qui bug parfois:
l'edition de la endDateTime qui peut marcher parfois mais apres la valeur disparaît:
