Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest is no longer adding labels #146

Closed
benjivesterby opened this issue Dec 19, 2021 · 7 comments
Closed

latest is no longer adding labels #146

benjivesterby opened this issue Dec 19, 2021 · 7 comments
Labels
bug Something isn't working released

Comments

@benjivesterby
Copy link

benjivesterby commented Dec 19, 2021

🐞 Describe the bug

I have this setup for a number of repositories. I was using latest and I've also tried @v1

This was working last time I added changes.

📚 To Reproduce

Run workflow with labels specified

💡 Expected behavior

The label should be added to the PR

🖼️ Screenshots

Here is one of the PRs from the last couple runs with latest and @v1: PR

I tried running multiple times and the label is not added.

⚙️ Environment

  • Action version: latest
@benjivesterby benjivesterby added the bug Something isn't working label Dec 19, 2021
@benjivesterby
Copy link
Author

I've verified that this is not an issue in v1.15.5 Also, the assignee is not being set in the latest.
Here's a PR with v1.15.5 working: devnw/bridgekeeper#24

@benjivesterby
Copy link
Author

I removed the link to the workflow since I updated it to use v1.15.5.

@BetaHuhn
Copy link
Owner

If it does work in v1.15.5, then I suspect that 80e77fd broke the labels and assignees.

Will take a closer look.

@BetaHuhn
Copy link
Owner

I might have found the issue already, could you please try the fix on the develop branch:

uses: BetaHuhn/repo-file-sync-action@develop

@benjivesterby
Copy link
Author

@BetaHuhn Yup, looks like that fixed it

@BetaHuhn
Copy link
Owner

Great, will merge it into master and release the fix.

@BetaHuhn
Copy link
Owner

This issue is resolved in version v1.16.1 🎉

To use the latest version, use the Action with the v1 or latest tag:

uses: BetaHuhn/repo-file-sync-action@v1

Also thanks for supporting me via GitHub Sponsors @benjivesterby!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

2 participants