Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rootFiberNode 是不是改成 fiberRootNode 会比较好？ #23

Closed
ParadeTo opened this issue Jul 25, 2020 · 2 comments
Closed

rootFiberNode 是不是改成 fiberRootNode 会比较好？ #23

ParadeTo opened this issue Jul 25, 2020 · 2 comments

Comments

@ParadeTo
Copy link
Contributor

ParadeTo commented Jul 25, 2020 •
edited

原因有以下几点：

  • 因为是由 FiberRootNode 实例化而来

  • rootFiberNode 和 rootFiber 意思感觉有点相近，容易混淆

  • fiberRootNode 语义更符合，表示 fiber 树的根节点，而 rootFiberNode 则表示根 fiber 节点

  • 源码中叫 fiberRoot

如果你觉得需要改的话，我可以贡献一个 PR 😆
@JunlinZhu-Tommy
Copy link
Contributor

同意，fiberRootNode更能代表是整个应用的根结点。

@BetaSu
Copy link
Owner

BetaSu commented Jul 26, 2020

很好的建议，欢迎PR

@ParadeTo ParadeTo mentioned this issue Jul 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ParadeTo @BetaSu @JunlinZhu-Tommy