Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github workflow not respecting tests errors #17

Closed
beto-rodriguez opened this issue Mar 30, 2021 · 2 comments
Closed

Github workflow not respecting tests errors #17

beto-rodriguez opened this issue Mar 30, 2021 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@beto-rodriguez
Copy link
Owner

beto-rodriguez commented Mar 30, 2021

It compiles properly, but when calling dotnet test the unit test fails, and the workflow completes successfully.

https://github.com/beto-rodriguez/LiveCharts2/runs/2230526598#step:4:262

(I think the link is not working property unless you copy and paste it in the browser address bar)

But Github says the build was successful.

What am I missing?

@beto-rodriguez beto-rodriguez added the help wanted Extra attention is needed label Mar 30, 2021
@riQQ
Copy link

riQQ commented Mar 30, 2021

Maybe try this: https://github.com/Tyrrrz/GitHubActionsTestLogger

@beto-rodriguez
Copy link
Owner Author

@riQQ Thanks that guide me also.

Creating a new step to run the unit tests worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants