New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for granularity functions #2

Closed

betodealmeida opened this issue Sep 21, 2018 · 2 comments

Owner

betodealmeida commented Sep 21, 2018

We need to add proper support for granularity functions, so it can be used in Superset. The current PR (apache/superset#5915) is incorrect.

Owner Author

betodealmeida commented Sep 22, 2018

Here's how Presto does it: https://github.com/apache/incubator-superset/blob/84ae884c5ddffb65378654fe17afd5526cae039c/superset/db_engine_specs.py#L670-L686

Owner Author

betodealmeida commented Oct 29, 2018

Implemented in 4cbcff2.

betodealmeida closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment