Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom time format #77

Closed
michaelmob opened this issue Oct 29, 2018 · 4 comments
Closed

Custom time format #77

michaelmob opened this issue Oct 29, 2018 · 4 comments

Comments

@michaelmob
Copy link

michaelmob commented Oct 29, 2018

Date string is formatted to add custom text.
Could we customize the time format? It would allow a 12-hour clock to be possible.

The flag for i3lock would be something like --timestr '%l:%H:%S %p'

Would you accept a pull request for this? If so, what should the flag be?

@AUTplayed
Copy link
Collaborator

I think a flag that passes all arguments after it directly to the i3lock command would be beneficial (also reworking the command parsing should be done sometime soon as well)

just my opinion, maybe someone else has a better idea

@michaelmob
Copy link
Author

That would be even better.
How does two hyphens sound for that?

betterlockscreen --lock -- --timestr '%l:%H:%S %p'

May look sort of convoluted.

@michaelmob
Copy link
Author

Looking at the way variables are currently handled, I definitely agree that the command parsing rework is necessary before something like this should be added.

Considering betterlockscreen uses tools that utilize GNU programs, getopt (as opposed to getopts which cannot do long flags) would probably be one of the better options.

@michaelmob
Copy link
Author

Possible with #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants