Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time picker stays open when date picker is closed #1

Closed
d3chapma opened this issue Jul 19, 2014 · 10 comments
Closed

Time picker stays open when date picker is closed #1

d3chapma opened this issue Jul 19, 2014 · 10 comments

Comments

@d3chapma
Copy link

In the demo, engage rome on the first input. Click to select a time. Then click away to exit the date picker without selecting a time. The time picker stays open and the data picker closes.

@bevacqua
Copy link
Owner

on which browser? I can't reproduce this

@d3chapma
Copy link
Author

Chrome 35 Mac

@bevacqua
Copy link
Owner

I followed these steps and it was a no-repo

  • Click on input
  • Click on time on the calendar
  • Click dark orange area
  • Click on input again
  • Calendar opens, but time picker is closed..

@d3chapma
Copy link
Author

After:

  • Click on input
  • Click on time on the calendar
  • Click dark orange area
    I see this:
    screen shot 2014-07-19 at 12 13 49 am

@bevacqua
Copy link
Owner

Not sure how this can happen as the time dropdown should be hidden together with the calendar

Also the time list is only shown when clicking on the time or when opening the calendar (but if o.date is false)

@brayniverse
Copy link

This happens to me as well, using Chrome v35.0.1916.114

@mscdex
Copy link

mscdex commented Jul 19, 2014

I noticed this too, but it seems to be a rendering bug in the browser? You can't interact (e.g. scroll the list, click an entry, etc.) with the region that's left behind. It goes away when you try clicking around or highlighting the "{ time: false }" text behind it.

EDIT: This is on Chrome 36.0.1985.125 on Windows.
EDIT 2: It doesn't happen in Firefox (30.0 on Windows).

@bevacqua
Copy link
Owner

Could reproduce on Safari. Fixed (952e714, v0.3.6). Definitely a browser rendering bug, I got around it by hiding the time list and then hiding the calendar in the next frame.

@d3chapma
Copy link
Author

Yup. This is fixed for me now. Good work tracking down a fix.

@brayniverse
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants