-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change after version 2.0.1 with Node v0.6 #1
Comments
The problem is with cyclic.js and the existsSync function on line 1. Which is not available before node v0.8 (was path.existsSync) The Watchr library is depending on "typechecker": "~2.0.1", which is now broken on node v0.6. The change to fs.existsSync is breaking other dependencies at the moment. Here is a solution for making cyclic.js work again with older versions of node.
So the problem can be solved by using lstatSync with a try/catch around it. Easy! I tried
Any chance you can fix this minor compatibility issue? Thanks! |
+1. Facing the same issue. Would be good to get this compatibility fixed. |
What is the purpose of this file cyclic.js, and why has it found its way into so many projects? |
@amb26 if project A has a development dependency called project B that has a dependency of project A, then that creates a cyclic dependency, which npm will error about, cyclic.js fixes that error. I'm unsure if newer versions of npm still have this issue. |
TypeChecker will be updated in coming months when it is converted along with our over projects to ES6, and will get this update - details. As it seems this update is only for Node 0.6 from 2013, I don't think this of any urgency. |
Removed |
Recently I'm getting Travis built errors on an existing node module testing on Node v0.6.19.
This module is using Watchr, which is using type checker ~2.0.1 as a dependency.
It seems you introduced a breaking change somewhere after 2.0.1, but only marked it as a patch (by only updating the last number of the version.)
I recommend going back and change the version to 2.1.x and rollback the breaking change after 2.0.1.
Cheers!
The text was updated successfully, but these errors were encountered: